Sync eng/common directory with azure-sdk-tools for PR 1564 #18174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This removes the ci.yml filtering which means all projects can be discovered - This eliminates the need for the yml parsing module for most common scenarios - This does introduce some potential issues with duplicate package names for languages like java. The only known case currently is azure-storage-blobs and if there is ever a need to explicitly pick the correct one someone can pass in the ServiceDirectory filter similar to "storage/azure*" for new and "storage/microsoft*" for the older sdk. By default azure usually comes first so the new one gets discovered which is likely all we need for now. If this turns out not to be true we might need another way to disambiguate.
azure-sdk
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
azure-sdk
added
Central-EngSys
weshaggard
approved these changes
Apr 20, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Apr 22, 2021
…into azure_purview_catalog * 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits) update FormField docstring (Azure#18226) [Event Hubs] combine conn str parsing logic (Azure#18059) [Blob]Edit Test for Single Thread Substream Retry (Azure#18206) maintenance changelog config (Azure#18216) Privated hierarchy traversal and fixed encryption algorithm (Azure#18212) Remove duplicate calls to bypass-local-dns.yml (Azure#18180) Patch changelog (Azure#18188) enable polling by default (Azure#18184) [Communication]: Added identity exception tests (Azure#18191) version (Azure#18202) [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166) Updated identity samples (Azure#18189) Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155) Clean Up PR Triggers (Azure#18186) [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181) Add environment.yml to unify conda versioning (Azure#18141) [Fix]Add retry for streaming download (Azure#18164) Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178) Stop filtering projects by ci.yml files (Azure#18174) [Communication] - SDK - Added contributing file (Azure#18018) ...
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Apr 27, 2022
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (Azure#18174) * Adding details about access and Report Schema for reservation report * MISC * Missing errors * fixing model error * MISC * MISC * MISC * MSIC * MISC * Removing Etag to fix the S360 item * Fixing Routing issue * MISC * MISC * MISC * MISC
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Apr 27, 2022
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2021-10-01 (Azure#18174) * Adding details about access and Report Schema for reservation report * MISC * Missing errors * fixing model error * MISC * MISC * MISC * MSIC * MISC * Removing Etag to fix the S360 item * Fixing Routing issue * MISC * MISC * MISC * MISC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1564 See eng/common workflow